X-Git-Url: http://j8takagi.net/cgi-bin/gitweb.cgi?p=YACASL2.git;a=blobdiff_plain;f=src%2Fassemble.c;h=fc7aed16418af9bbb5c7c45a676e5f3bfc5887ca;hp=272f2f8b001a84a8241e15e14a98c761b15e64d5;hb=f9ad3a081e1777bb6d892af65d0e4090cb31bbfa;hpb=d1f82970bf7d41db2fea11b08cd8e308f6cb8138

diff --git a/src/assemble.c b/src/assemble.c
index 272f2f8..fc7aed1 100644
--- a/src/assemble.c
+++ b/src/assemble.c
@@ -13,9 +13,9 @@
 ASMODE asmode = {false, false, false, false, false};
 
 /**
- * アセンブルのプロパティ
+ * アセンブル時の、現在およびリテラルのアドレスとプログラム入口名: ptr, lptr, prog
  */
-ASPROP *asprop;
+ASPTR *asptr;
 
 /**
  * アセンブルのエラー定義
@@ -24,8 +24,6 @@ static CERR cerr_assemble[] = {
     { 101, "label already defined" },
     { 102, "label table is full" },
     { 103, "label not found" },
-    { 104, "label length is too long" },
-    { 105, "no command in the line" },
     { 106, "operand mismatch in assemble command" },
     { 107, "no label in START" },
     { 108, "not command of operand \"r\"" },
@@ -34,48 +32,44 @@ static CERR cerr_assemble[] = {
     { 111, "not command of operand \"adr[,x]\"" },
     { 112, "not command of no operand" },
     { 113, "operand too many in COMET II command" },
-    { 117, "operand too many in DC" },
-    { 118, "operand length too long" },
     { 119, "out of COMET II memory" },
     { 120, "GR0 in operand x" },
-    { 121, "cannot get operand token" },
     { 122, "cannot create hash table" },
-    { 123, "unclosed quote" },
     { 124, "more than one character in literal" },
     { 125, "not GR in operand x" },
 };
 
-#ifndef UNITTEST
-static WORD getadr(const char *prog, const char *str, PASS pass);
+WORD getadr(const char *prog, const char *str, PASS pass);
 
-static WORD getgr(const char *str, bool is_x);
+WORD getgr(const char *str, bool is_x);
 
-static WORD getliteral(const char *str, PASS pass);
+WORD getliteral(const char *str, PASS pass);
 
-static bool assemblecmd(const CMDLINE *cmdl, PASS pass);
+bool assemblecmd(const CMDLINE *cmdl, PASS pass);
 
-static bool macrocmd(const CMDLINE *cmdl, PASS pass);
+bool macrocmd(const CMDLINE *cmdl, PASS pass);
 
-static bool writeIN(const char *ibuf, const char *len, PASS pass);
+void writeIN(const char *ibuf, const char *len, PASS pass);
 
-static bool writeOUT(const char *obuf, const char *len, PASS pass);
+void writeOUT(const char *obuf, const char *len, PASS pass);
 
-static bool writeRPUSH(PASS pass);
+void writeRPUSH(PASS pass);
 
-static bool writeRPOP(PASS pass);
+void writeRPOP(PASS pass);
 
-static bool cometcmd(const CMDLINE *cmdl, PASS pass);
+bool cometcmd(const CMDLINE *cmdl, PASS pass);
 
-static bool writememory(WORD word, WORD adr, PASS pass);
+bool writememory(WORD word, WORD adr, PASS pass);
 
-static void writestr(const char *str, bool literal, PASS pass);
+void writestr(const char *str, bool literal, PASS pass);
 
-static void writeDC(const char *str, PASS pass);
+void writeDC(const char *str, PASS pass);
 
-static bool assembleline(const CMDLINE *cmdl, PASS pass);
+bool assembletok(const CMDLINE *cmdl, PASS pass);
 
-static void printline(FILE *stream, const char *filename, int lineno, char *line);
-#endif
+bool assembleline(const char *line, PASS pass);
+
+void printline(FILE *stream, const char *filename, int lineno, char *line);
 
 /**
  * 汎用レジスタを表す文字列「GR[0-7]」から、レジスタ番号[0-7]をWORD値で返す
@@ -86,6 +80,7 @@ WORD getgr(const char *str, bool is_x)
 {
     assert(str != NULL);
     WORD r;
+
     /* 「GR[0-7]」以外の文字列では、0xFFFFを返して終了 */
     if(!(strlen(str) == 3 && strncmp(str, "GR", 2) == 0 &&
          (*(str+2) >= '0' && *(str+2) <= '0' + (GRSIZE - 1))))
@@ -107,12 +102,13 @@ WORD getgr(const char *str, bool is_x)
  */
 WORD getliteral(const char *str, PASS pass)
 {
-    WORD adr = asprop->lptr;
     assert(*str == '=');
+    WORD adr = asptr->lptr;
+
     if(*(++str) == '\'') {    /* 文字定数 */
         writestr(str, true, pass);
     } else {
-        writememory(nh2word(str), (asprop->lptr)++, pass);
+        writememory(nh2word(str), (asptr->lptr)++, pass);
     }
     return adr;
 }
@@ -153,30 +149,30 @@ bool assemblecmd(const CMDLINE *cmdl, PASS pass)
             return false;
         }
         /* プログラム名の設定 */
-        asprop->prog = strdup_chk(cmdl->label, "asprop.prog");
-        /* オペランドがある場合、実行開始番地を設定 */
+        asptr->prog = strdup_chk(cmdl->label, "asptr.prog");
+        /* オペランドがある場合、実行開始アドレスを設定 */
         if(pass == SECOND && cmdl->opd->opdc == 1) {
-            if((prog->start = getlabel(asprop->prog, cmdl->opd->opdv[0])) == 0xFFFF) {
+            if((execptr->start = getlabel(asptr->prog, cmdl->opd->opdv[0])) == 0xFFFF) {
                 setcerr(103, cmdl->opd->opdv[0]);    /* label not found */
             }
         }
         status = true;
         break;
     case END:
-        /* リテラル領域の設定 */
+        /* 1回目のアセンブルの場合は、リテラル領域開始アドレスを設定 */
         if(pass == FIRST) {
-            asprop->lptr = asprop->ptr;
+            asptr->lptr = asptr->ptr;
         }
-        /* 実行終了番地と次のプログラムの実行開始番地を設定 */
+        /* 2回目のアセンブルの場合は、リテラル領域終了アドレスを実行終了アドレスとして設定 */
         else if(pass == SECOND) {
-            prog->end = asprop->lptr;
+            execptr->end = asptr->lptr;
         }
-        asprop->prog = NULL;
+        FREE(asptr->prog);
         status = true;
         break;
     case DS:
         for(i = 0; i < atoi(cmdl->opd->opdv[0]); i++) {
-            writememory(0x0, (asprop->ptr)++, pass);
+            writememory(0x0, (asptr->ptr)++, pass);
             if(cerr->num > 0) {
                 return false;
             }
@@ -209,8 +205,7 @@ bool assemblecmd(const CMDLINE *cmdl, PASS pass)
 bool macrocmd(const CMDLINE *cmdl, PASS pass)
 {
     int i = 0;
-    MACROCMDID cmdid;
-    bool status = false;
+    MACROCMDID cmdid = 0;
     MACROCMD macrocmd[] = {
         { IN, 2, 2, "IN" },
         { OUT, 2, 2, "OUT" },
@@ -234,21 +229,20 @@ bool macrocmd(const CMDLINE *cmdl, PASS pass)
     switch(cmdid)
     {
     case IN:
-        status = writeIN(cmdl->opd->opdv[0], cmdl->opd->opdv[1], pass);
-        break;
+        writeIN(cmdl->opd->opdv[0], cmdl->opd->opdv[1], pass);
+        return true;
     case OUT:
-        status = writeOUT(cmdl->opd->opdv[0], cmdl->opd->opdv[1], pass);
-        break;
+        writeOUT(cmdl->opd->opdv[0], cmdl->opd->opdv[1], pass);
+        return true;
     case RPUSH:
-        status = writeRPUSH(pass);
-        break;
+        writeRPUSH(pass);
+        return true;
     case RPOP:
-        status = writeRPOP(pass);
-        break;
+        writeRPOP(pass);
+        return true;
     default:
         return false;
     }
-    return status;
 }
 
 /**
@@ -261,33 +255,21 @@ bool macrocmd(const CMDLINE *cmdl, PASS pass)
  *      POP GR2
  *      POP GR1
  */
-bool writeIN(const char *ibuf, const char *len, PASS pass)
+void writeIN(const char *ibuf, const char *len, PASS pass)
 {
-    bool status = false;
-
-    /* PUSH 0,GR1 */
-    writememory(0x7001, (asprop->ptr)++, pass);
-    writememory(0x0, (asprop->ptr)++, pass);
-    /* PUSH 0,GR2 */
-    writememory(0x7002, (asprop->ptr)++, pass);
-    writememory(0x0, (asprop->ptr)++, pass);
-    /* LAD GR1,IBUF */
-    writememory(0x1210, (asprop->ptr)++, pass);
-    writememory(getadr(asprop->prog, ibuf, pass), (asprop->ptr)++, pass);
-    /* LAD GR2,LEN */
-    writememory(0x1220, (asprop->ptr)++, pass);
-    writememory(getadr(asprop->prog, len, pass), (asprop->ptr)++, pass);
-    /* SVC 1 */
-    writememory(0xF000, (asprop->ptr)++, pass);
-    writememory(0x0001, (asprop->ptr)++, pass);
-    /* POP GR2 */
-    writememory(0x7120, (asprop->ptr)++, pass);
-    /* POP GR1 */
-    writememory(0x7110, (asprop->ptr)++, pass);
-    if(cerr->num == 0) {
-        status = true;
-    }
-    return status;
+    char *line = malloc_chk(LINESIZE + 1, "writeIN.line");
+
+    assembleline("    PUSH 0,GR1", pass);
+    assembleline("    PUSH 0,GR2", pass);
+    sprintf(line, "    LAD GR1,%s", ibuf);
+    assembleline(line, pass);
+    sprintf(line, "    LAD GR2,%s", len);
+    assembleline(line, pass);
+    assembleline("    SVC 1", pass);
+    assembleline("    POP GR2", pass);
+    assembleline("    POP GR1", pass);
+
+    FREE(line);
 }
 
 /**
@@ -298,57 +280,28 @@ bool writeIN(const char *ibuf, const char *len, PASS pass)
  *      LAD GR2,LEN
  *      SVC 2
  *      LAD GR1,=#A
- *      LAD GR2,1
+ *      LAD GR2,=1
  *      SVC 2
  *      POP GR2
  *      POP GR1
  */
-bool writeOUT(const char *obuf, const char *len, PASS pass)
+void writeOUT(const char *obuf, const char *len, PASS pass)
 {
-    bool status = false;
-
-    /* PUSH 0,GR1 */
-    writememory(0x7001, (asprop->ptr)++, pass);
-    writememory(0x0, (asprop->ptr)++, pass);
-    /* PUSH 0,GR2 */
-    writememory(0x7002, (asprop->ptr)++, pass);
-    writememory(0x0, (asprop->ptr)++, pass);
-    /* LAD GR1,OBUF */
-    writememory(0x1210, (asprop->ptr)++, pass);
-    writememory(getadr(asprop->prog, obuf, pass), (asprop->ptr)++, pass);
-    /* LAD GR2,OLEN */
-    writememory(0x1220, (asprop->ptr)++, pass);
-    writememory(getadr(asprop->prog, len, pass), (asprop->ptr)++, pass);
-    /* SVC 2 */
-    writememory(0xF000, (asprop->ptr)++, pass);
-    writememory(0x0002, (asprop->ptr)++, pass);
-    /* LAD GR1,=#A */
-    writememory(0x1210, (asprop->ptr)++, pass);
-    if(pass == FIRST) {
-        (asprop->ptr)++;
-    } else {
-        writememory(asprop->lptr, (asprop->ptr)++, pass);    /* リテラルのアドレスを書込 */
-    }
-    writememory(0xA, (asprop->lptr)++, pass);
-    /* LAD GR2,=1 */
-    writememory(0x1220, (asprop->ptr)++, pass);
-    if(pass == FIRST) {
-        (asprop->ptr)++;
-    } else {
-        writememory(asprop->lptr, (asprop->ptr)++, pass);    /* リテラルのアドレスを書込 */
-    }
-    writememory(0x1, (asprop->lptr)++, pass);
-    /* SVC 2 */
-    writememory(0xF000, (asprop->ptr)++, pass);
-    writememory(0x0002, (asprop->ptr)++, pass);
-    /* POP GR2 */
-    writememory(0x7120, (asprop->ptr)++, pass);
-    /* POP GR1 */
-    writememory(0x7110, (asprop->ptr)++, pass);
-    if(cerr->num == 0) {
-        status = true;
-    }
-    return status;
+    char *line = malloc_chk(LINESIZE + 1, "writeOUT.line");
+
+    assembleline("    PUSH 0,GR1", pass);
+    assembleline("    PUSH 0,GR2", pass);
+    sprintf(line, "    LAD GR1,%s", obuf);
+    assembleline(line, pass);
+    sprintf(line, "    LAD GR2,%s", len);
+    assembleline(line, pass);
+    assembleline("    SVC 2", pass);
+    assembleline("    LAD GR1,=#A", pass);
+    assembleline("    LAD GR2,=1", pass);
+    assembleline("    SVC 2", pass);
+    assembleline("    POP GR2", pass);
+    assembleline("    POP GR1", pass);
+    FREE(line);
 }
 
 /** マクロ命令「RPUSH」をメモリに書き込む
@@ -360,19 +313,16 @@ bool writeOUT(const char *obuf, const char *len, PASS pass)
  *       PUSH 0,GR6
  *       PUSH 0,GR7
  */
-bool writeRPUSH(PASS pass)
+void writeRPUSH(PASS pass)
 {
     int i;
-    bool status = false;
+    char *line = malloc_chk(LINESIZE + 1, "writeRPUSH.line");
 
-    for(i = 1; i <= 7; i++) {
-        writememory(0x7000 + i, (asprop->ptr)++, pass);   /* PUSH GRn */
-        writememory(0x0, (asprop->ptr)++, pass);
+    for(i = 1; i <= GRSIZE-1; i++) {
+        sprintf(line, "    PUSH 0,GR%d", i);
+        assembleline(line, pass);
     }
-    if(cerr->num == 0) {
-        status = true;
-    }
-    return status;
+    FREE(line);
 }
 
 /**
@@ -386,22 +336,21 @@ bool writeRPUSH(PASS pass)
  *      POP GR2
  *      POP GR1
  */
-bool writeRPOP(PASS pass)
+void writeRPOP(PASS pass)
 {
     int i;
-    bool status = false;
-    for(i = 7; i >= 1; i--) {
-        writememory((0x7100 + (i << 4)), (asprop->ptr)++, pass);  /* POP GRn */
-    }
-    if(cerr->num == 0) {
-        status = true;
+    char *line = malloc_chk(LINESIZE + 1, "writeRPOP.line");
+
+    for(i = GRSIZE-1; i >= 1; i--) {
+        sprintf(line, "    POP GR%d", i);
+        assembleline(line, pass);
     }
-    return status;
+    FREE(line);
 }
 
 /**
  * 機械語命令をメモリに書込
- * 書込に成功した場合はtrue、それ以外の場合はfalseを返す
+ * 書込に、成功した場合はtrue、失敗した場合はfalse、を返す
  */
 bool cometcmd(const CMDLINE *cmdl, PASS pass)
 {
@@ -414,7 +363,7 @@ bool cometcmd(const CMDLINE *cmdl, PASS pass)
             setcerr(112, cmdl->cmd);    /* not command of no operand */
             return false;
         }
-        if(writememory(cmd, (asprop->ptr)++, pass) == true) {
+        if(writememory(cmd, (asptr->ptr)++, pass) == true) {
             status = true;
         }
     }
@@ -427,7 +376,7 @@ bool cometcmd(const CMDLINE *cmdl, PASS pass)
                 return false;
             }
             cmd |= (r1 << 4);
-            if(writememory(cmd, (asprop->ptr)++, pass) == true) {
+            if(writememory(cmd, (asptr->ptr)++, pass) == true) {
                 status = true;
             }
         }
@@ -438,16 +387,14 @@ bool cometcmd(const CMDLINE *cmdl, PASS pass)
                 return false;
             }
             cmd |= ((r1 << 4) | r2);
-            if(cerr->num == 0 && writememory(cmd, (asprop->ptr)++, pass) == true) {
+            if(cerr->num == 0 && writememory(cmd, (asptr->ptr)++, pass) == true) {
                 status = true;
             }
         }
-        /* オペランド数2〜3。第2オペランドはアドレス、 */
+        /* オペランド数2または3。第2オペランドはアドレス、 */
         /* 第3オペランドは指標レジスタとして用いる汎用レジスタ */
         else if(cmdl->opd->opdc == 2 || cmdl->opd->opdc == 3) {
-            if((cmd = getcmdcode(cmdl->cmd, R_ADR_X_)) == 0xFFFF &&
-               (cmd = getcmdcode(cmdl->cmd, R_ADR_X)) == 0xFFFF)
-            {
+            if((cmd = getcmdcode(cmdl->cmd, R_ADR_X)) == 0xFFFF) {
                 setcerr(110, cmdl->cmd);    /* not command of operand "r,adr[,x]" */
                 return false;
             }
@@ -460,9 +407,9 @@ bool cometcmd(const CMDLINE *cmdl, PASS pass)
                 }
                 cmd |= x;
             }
-            adr = getadr(asprop->prog, cmdl->opd->opdv[1], pass);
-            writememory(cmd, (asprop->ptr)++, pass);
-            writememory(adr, (asprop->ptr)++, pass);
+            adr = getadr(asptr->prog, cmdl->opd->opdv[1], pass);
+            writememory(cmd, (asptr->ptr)++, pass);
+            writememory(adr, (asptr->ptr)++, pass);
             if(cerr->num == 0) {
                 status = true;
             }
@@ -471,7 +418,7 @@ bool cometcmd(const CMDLINE *cmdl, PASS pass)
             return false;
         }
     }
-    /* オペランド数1〜2。第1オペランドはアドレス */
+    /* オペランド数1または2。第1オペランドはアドレス */
     else if(cmdl->opd->opdc == 1 || cmdl->opd->opdc == 2) {
         if((cmd = getcmdcode(cmdl->cmd, ADR_X)) == 0xFFFF) {
             setcerr(111, cmdl->cmd);    /* not command of operand "adr[,x]" */
@@ -492,10 +439,10 @@ bool cometcmd(const CMDLINE *cmdl, PASS pass)
             adr = getlabel(NULL, cmdl->opd->opdv[0]);
         }
         if(cmd != 0x8000 || (pass == SECOND && adr == 0xFFFF)) {
-            adr = getadr(asprop->prog, cmdl->opd->opdv[0], pass);
+            adr = getadr(asptr->prog, cmdl->opd->opdv[0], pass);
         }
-        writememory(cmd, (asprop->ptr)++, pass);
-        writememory(adr, (asprop->ptr)++, pass);
+        writememory(cmd, (asptr->ptr)++, pass);
+        writememory(adr, (asptr->ptr)++, pass);
         if(cerr->num == 0) {
             status = true;
         }
@@ -529,7 +476,7 @@ bool writememory(WORD word, WORD adr, PASS pass)
  */
 void writestr(const char *str, bool literal, PASS pass)
 {
-    assert(cerr->num == 0 && *str == '\'');
+    assert(*str == '\'');
     const char *p = str + 1;
     bool lw = false;
 
@@ -548,10 +495,10 @@ void writestr(const char *str, bool literal, PASS pass)
         }
         /*リテラルの場合はリテラル領域に書込 */
         if(literal == true) {
-            writememory(*(p++), (asprop->lptr)++, pass);
+            writememory(*(p++), (asptr->lptr)++, pass);
             lw = true;
         } else {
-            writememory(*(p++), (asprop->ptr)++, pass);
+            writememory(*(p++), (asptr->ptr)++, pass);
         }
     }
 }
@@ -562,32 +509,31 @@ void writestr(const char *str, bool literal, PASS pass)
 void writeDC(const char *str, PASS pass)
 {
     WORD adr = 0x0;
+
     if(*str == '\'') {
         writestr(str, false, pass);
     } else {
         if(*str == '#' || isdigit(*str) || *str == '-') {
             adr = nh2word(str);
         } else {
-            if(pass == SECOND && (adr = getlabel(asprop->prog, str)) == 0xFFFF) {
+            if(pass == SECOND && (adr = getlabel(asptr->prog, str)) == 0xFFFF) {
                 setcerr(103, str);    /* label not found */
             }
         }
-        writememory(adr, (asprop->ptr)++, pass);
+        writememory(adr, (asptr->ptr)++, pass);
     }
 }
 
 /**
- * 1行をアセンブル
+ * トークンをアセンブル
  */
-bool assembleline(const CMDLINE *cmdl, PASS pass)
+bool assembletok(const CMDLINE *cmdl, PASS pass)
 {
     bool status = false;
+
     /* 命令がない場合 */
     if(cmdl->cmd == NULL){
-        /* ラベルが定義されていて命令がない場合はエラー */
-        if(cmdl->label != NULL) {
-            setcerr(105, NULL);    /* no command in the line */
-        }
+        ;
     }
     /* アセンブラ命令の処理 */
     else if(cerr->num == 0 && assemblecmd(cmdl, pass) == true) {
@@ -626,6 +572,7 @@ void printline(FILE *stream, const char *filename, int lineno, char *line)
 WORD getadr(const char *prog, const char *str, PASS pass)
 {
     WORD adr = 0x0;
+
     if(*str == '=') {
         adr = getliteral(str, pass);
     } else if(isdigit(*str) || *str == '-' || *str == '#') {
@@ -640,58 +587,85 @@ WORD getadr(const char *prog, const char *str, PASS pass)
     return adr;
 }
 
+
+/**
+ * 1行をアセンブル
+ */
+bool assembleline(const char *line, PASS pass)
+{
+    CMDLINE *cmdl;
+    bool status = true;
+    int i;
+
+    cmdl = linetok(line);
+    status = (cerr->num == 0) ? true : false;
+    if(cmdl != NULL) {
+        if(status == true) {
+            if(pass == FIRST && cmdl->label != NULL) {
+                status = addlabel(asptr->prog, cmdl->label, asptr->ptr);
+            }
+            if(status == true) {
+                status = assembletok(cmdl, pass);
+            }
+            FREE(cmdl->label);
+        }
+        if(cmdl->opd != NULL) {
+            for(i = 0; i < cmdl->opd->opdc; i++) {
+                FREE(cmdl->opd->opdv[i]);
+            }
+        }
+        FREE(cmdl->opd);
+        FREE(cmdl->cmd);
+    }
+    FREE(cmdl);
+    return status;
+}
+
+/**
+ * アセンブルのエラーをエラーリストに追加
+ */
+void addcerrlist_assemble()
+{
+    addcerrlist_tok();
+    addcerrlist_word();
+    addcerrlist_label();
+    addcerrlist(ARRAYSIZE(cerr_assemble), cerr_assemble);
+}
+
 /**
  * 指定された名前のファイルをアセンブル
- * 2回実行される
+ * 1回目ではラベルを登録し、2回目ではラベルからアドレスを読み込む
+ * アセンブル完了時はtrue、エラー発生時はfalseを返す
  */
-bool assemble(const char *file, PASS pass)
+bool assemblefile(const char *file, PASS pass)
 {
     int lineno = 0;
-    bool status = true;
-    CMDLINE *cmdl;
     char *line;
     FILE *fp;
 
-    addcerrlist(ARRAYSIZE(cerr_assemble), cerr_assemble);
     if((fp = fopen(file, "r")) == NULL) {
         perror(file);
         return false;
     }
-    for(; ;) {
-        cmdl = malloc_chk(sizeof(CMDLINE), "cmdl");
-        line = malloc_chk(LINESIZE + 1, "line");
-        if((line = fgets(line, LINESIZE, fp)) == NULL) {
-            break;
-        }
+    line = malloc_chk(LINESIZE + 1, "assemble.line");
+    while(fgets(line, LINESIZE, fp)) {
         lineno++;
         if((pass == FIRST && asmode.src == true) ||
            (pass == SECOND && asmode.asdetail == true))
         {
             printline(stdout, file, lineno, line);
         }
-        if((cmdl = linetok(line)) != NULL) {
-            if(pass == FIRST && cmdl->label != NULL) {
-                if(addlabel(asprop->prog, cmdl->label, asprop->ptr) == false) {
-                    break;
-                }
-            }
-            if(assembleline(cmdl, pass) == false) {
-                break;
-            }
-        }
-        if(cerr->num > 0) {
+        if(assembleline(line, pass) == false) {
             break;
         }
-        free_chk(line, "line");
-        free_chk(cmdl, "cmdl");
     }
     if(cerr->num > 0) {
         fprintf(stderr, "Assemble error - %d: %s\n", cerr->num, cerr->msg);
         printline(stderr, file, lineno, line);
-        status = false;
     }
+    FREE(line);
     fclose(fp);
-    return status;
+    return (cerr->num == 0) ? true : false;
 }
 
 /**
@@ -705,6 +679,6 @@ void outassemble(const char *file)
         perror(file);
         exit(-1);
     }
-    fwrite(sys->memory, sizeof(WORD), prog->end, fp);
+    fwrite(sys->memory, sizeof(WORD), execptr->end, fp);
     fclose(fp);
 }