X-Git-Url: http://j8takagi.net/cgi-bin/gitweb.cgi?p=YACASL2.git;a=blobdiff_plain;f=src%2Fassemble.c;h=fc7aed16418af9bbb5c7c45a676e5f3bfc5887ca;hp=35c3e9f15a15e897583f38e751a877dcf906d4a7;hb=f9ad3a081e1777bb6d892af65d0e4090cb31bbfa;hpb=6b30a23640168f0b99e70ad87ab4c5a98015ee02;ds=sidebyside

diff --git a/src/assemble.c b/src/assemble.c
index 35c3e9f..fc7aed1 100644
--- a/src/assemble.c
+++ b/src/assemble.c
@@ -13,7 +13,7 @@
 ASMODE asmode = {false, false, false, false, false};
 
 /**
- * アセンブルのプロパティ: ptr, lptr, *prog
+ * アセンブル時の、現在およびリテラルのアドレスとプログラム入口名: ptr, lptr, prog
  */
 ASPTR *asptr;
 
@@ -80,6 +80,7 @@ WORD getgr(const char *str, bool is_x)
 {
     assert(str != NULL);
     WORD r;
+
     /* 「GR[0-7]」以外の文字列では、0xFFFFを返して終了 */
     if(!(strlen(str) == 3 && strncmp(str, "GR", 2) == 0 &&
          (*(str+2) >= '0' && *(str+2) <= '0' + (GRSIZE - 1))))
@@ -101,8 +102,9 @@ WORD getgr(const char *str, bool is_x)
  */
 WORD getliteral(const char *str, PASS pass)
 {
-    WORD adr = asptr->lptr;
     assert(*str == '=');
+    WORD adr = asptr->lptr;
+
     if(*(++str) == '\'') {    /* 文字定数 */
         writestr(str, true, pass);
     } else {
@@ -204,7 +206,7 @@ bool macrocmd(const CMDLINE *cmdl, PASS pass)
 {
     int i = 0;
     MACROCMDID cmdid = 0;
-     MACROCMD macrocmd[] = {
+    MACROCMD macrocmd[] = {
         { IN, 2, 2, "IN" },
         { OUT, 2, 2, "OUT" },
         { RPUSH, 0, 0, "RPUSH" },
@@ -255,7 +257,7 @@ bool macrocmd(const CMDLINE *cmdl, PASS pass)
  */
 void writeIN(const char *ibuf, const char *len, PASS pass)
 {
-    char *line = malloc_chk(LINESIZE+1, "writeIN.line");
+    char *line = malloc_chk(LINESIZE + 1, "writeIN.line");
 
     assembleline("    PUSH 0,GR1", pass);
     assembleline("    PUSH 0,GR2", pass);
@@ -285,7 +287,7 @@ void writeIN(const char *ibuf, const char *len, PASS pass)
  */
 void writeOUT(const char *obuf, const char *len, PASS pass)
 {
-    char *line = malloc_chk(LINESIZE+1, "writeOUT.line");
+    char *line = malloc_chk(LINESIZE + 1, "writeOUT.line");
 
     assembleline("    PUSH 0,GR1", pass);
     assembleline("    PUSH 0,GR2", pass);
@@ -314,7 +316,7 @@ void writeOUT(const char *obuf, const char *len, PASS pass)
 void writeRPUSH(PASS pass)
 {
     int i;
-    char *line = malloc_chk(LINESIZE+1, "writeRPUSH.line");
+    char *line = malloc_chk(LINESIZE + 1, "writeRPUSH.line");
 
     for(i = 1; i <= GRSIZE-1; i++) {
         sprintf(line, "    PUSH 0,GR%d", i);
@@ -337,7 +339,7 @@ void writeRPUSH(PASS pass)
 void writeRPOP(PASS pass)
 {
     int i;
-    char *line = malloc_chk(LINESIZE+1, "writeRPOP.line");
+    char *line = malloc_chk(LINESIZE + 1, "writeRPOP.line");
 
     for(i = GRSIZE-1; i >= 1; i--) {
         sprintf(line, "    POP GR%d", i);
@@ -392,9 +394,7 @@ bool cometcmd(const CMDLINE *cmdl, PASS pass)
         /* オペランド数2または3。第2オペランドはアドレス、 */
         /* 第3オペランドは指標レジスタとして用いる汎用レジスタ */
         else if(cmdl->opd->opdc == 2 || cmdl->opd->opdc == 3) {
-            if((cmd = getcmdcode(cmdl->cmd, R_ADR_X_)) == 0xFFFF &&
-               (cmd = getcmdcode(cmdl->cmd, R_ADR_X)) == 0xFFFF)
-            {
+            if((cmd = getcmdcode(cmdl->cmd, R_ADR_X)) == 0xFFFF) {
                 setcerr(110, cmdl->cmd);    /* not command of operand "r,adr[,x]" */
                 return false;
             }
@@ -476,7 +476,7 @@ bool writememory(WORD word, WORD adr, PASS pass)
  */
 void writestr(const char *str, bool literal, PASS pass)
 {
-    assert(cerr->num == 0 && *str == '\'');
+    assert(*str == '\'');
     const char *p = str + 1;
     bool lw = false;
 
@@ -509,6 +509,7 @@ void writestr(const char *str, bool literal, PASS pass)
 void writeDC(const char *str, PASS pass)
 {
     WORD adr = 0x0;
+
     if(*str == '\'') {
         writestr(str, false, pass);
     } else {
@@ -571,6 +572,7 @@ void printline(FILE *stream, const char *filename, int lineno, char *line)
 WORD getadr(const char *prog, const char *str, PASS pass)
 {
     WORD adr = 0x0;
+
     if(*str == '=') {
         adr = getliteral(str, pass);
     } else if(isdigit(*str) || *str == '-' || *str == '#') {
@@ -632,19 +634,20 @@ void addcerrlist_assemble()
 
 /**
  * 指定された名前のファイルをアセンブル
- * 2回実行される
+ * 1回目ではラベルを登録し、2回目ではラベルからアドレスを読み込む
+ * アセンブル完了時はtrue、エラー発生時はfalseを返す
  */
-bool assemble(const char *file, PASS pass)
+bool assemblefile(const char *file, PASS pass)
 {
     int lineno = 0;
-    bool status = true;
-    char *line = malloc_chk(LINESIZE + 1, "line");
+    char *line;
     FILE *fp;
 
     if((fp = fopen(file, "r")) == NULL) {
         perror(file);
         return false;
     }
+    line = malloc_chk(LINESIZE + 1, "assemble.line");
     while(fgets(line, LINESIZE, fp)) {
         lineno++;
         if((pass == FIRST && asmode.src == true) ||
@@ -659,11 +662,10 @@ bool assemble(const char *file, PASS pass)
     if(cerr->num > 0) {
         fprintf(stderr, "Assemble error - %d: %s\n", cerr->num, cerr->msg);
         printline(stderr, file, lineno, line);
-        status = false;
     }
     FREE(line);
     fclose(fp);
-    return status;
+    return (cerr->num == 0) ? true : false;
 }
 
 /**