X-Git-Url: http://j8takagi.net/cgi-bin/gitweb.cgi?p=YACASL2.git;a=blobdiff_plain;f=src%2Fword.c;h=3ad9a2b8ff3e0c676c92fb76fd9bf62120f9ffde;hp=74a2786bc381ca319a1a3db843f0dce7f6021096;hb=966fe49d988cbc63e0b58ca02514d89ce8f0bd1f;hpb=730611ebee687534d03ddfa6539b634a466e59fd

diff --git a/src/word.c b/src/word.c
index 74a2786..3ad9a2b 100644
--- a/src/word.c
+++ b/src/word.c
@@ -25,20 +25,11 @@ WORD n2word(const char *str);
  */
 WORD h2word(const char *str);
 
-/**
- * @brief wordのエラー定義
- */
-static CERR cerr_word[] = {
-    { 114, "not integer" },
-    { 115, "not hex" },
-    { 116, "out of hex range" },
-};
-
 WORD n2word(const char *str)
 {
-    assert(isdigit(*str) || *str == '-');
+    assert(isdigit(str[0]) || str[0] == '-');
 
-    char *check;
+    char *check = NULL;
     int n;
     /* WORD値に変換 */
     n = strtol(str, &check, 10);
@@ -55,10 +46,10 @@ WORD n2word(const char *str)
 
 WORD h2word(const char *str)
 {
-    assert(*str == '#');
+    assert(str[0] == '#');
 
-    WORD w = 0x0;
-    char *check;
+    WORD w = 0;
+    char *check = NULL;
     str++;
     if(*str == '-' || strlen(str) > 4) {
         setcerr(116, str-1);    /* out of hex range */
@@ -73,6 +64,15 @@ WORD h2word(const char *str)
     return w;
 }
 
+/**
+ * @brief wordのエラー定義
+ */
+static CERR cerr_word[] = {
+    { 114, "not integer" },
+    { 115, "not hex" },
+    { 116, "out of hex range" },
+};
+
 /* word.hで定義された関数群 */
 void addcerrlist_word()
 {
@@ -102,20 +102,19 @@ WORD nh2word(const char *str)
 char *word2n(WORD word)
 {
     enum {
-        MAXLEN = 5,        /* WORD値を10進数で表したときの最大桁数 */
+        MAXLEN = 5,        /* WORD値を10進数で表したときの最大けた数 */
     };
-    char *p = malloc_chk(MAXLEN + 1, "word2n.p"), *digit = malloc_chk(MAXLEN + 1, "word2n.digit");
-    int i = 0, j;
+    char *s = malloc_chk(MAXLEN + 1, "word2n.n");
+    char *t = NULL;
+    int d = 0;                  /* けた数 */
 
     do{
-        p[i++] = word % 10 + '0';
+        s[d++] = word % 10 + '0';
     } while((word /= 10) > 0);
-    for(j = 0; j < i; j++) {
-        digit[j] = p[(i-1)-j];
-    }
-    digit[j] = '\0';
-    FREE(p);
-    return digit;
+    s[d] = '\0';
+    t = strrev(s);
+    FREE(s);
+    return t;
 }
 
 char *word2bit(const WORD word)
@@ -124,9 +123,10 @@ char *word2bit(const WORD word)
         MAXLEN = 16,        /* WORD値を2進数で表したときの最大桁数 */
     };
     WORD mask = 0x8000;
-    char *bit = malloc_chk(MAXLEN + 1, "word2bit.bit");
+    char *bit = NULL;
     int i = 0;
 
+    bit = malloc_chk(MAXLEN + 1, "word2bit.bit");
     do {
         bit[i++] = (word & mask) ? '1' : '0';
     } while((mask >>= 1) > 0);
@@ -139,7 +139,7 @@ void print_dumpword(WORD word, bool logicalmode)
     char *bit = word2bit(word);
 
     if(logicalmode == true) {
-        fprintf(stdout, "%6d", word);
+        fprintf(stdout, "%6u", word);
     } else {
         fprintf(stdout, "%6d", (signed short)word);
     }